Skip to content

[AutoPR securityinsights/resource-manager] make alert rules endpoint get and return ScheduledAlertRule instead o…#4797

Closed
AutorestCI wants to merge 3 commits intorestapi_auto_securityinsights/resource-managerfrom
restapi_auto_5573
Closed

[AutoPR securityinsights/resource-manager] make alert rules endpoint get and return ScheduledAlertRule instead o…#4797
AutorestCI wants to merge 3 commits intorestapi_auto_securityinsights/resource-managerfrom
restapi_auto_5573

Conversation

@AutorestCI
Copy link
Copy Markdown
Contributor

@AutorestCI AutorestCI commented Apr 8, 2019

@AutorestCI
Generated from fe2f0eec69d4a91ca4881e03cd3e849ef519480f
a50ba93 
make alert rules endpoint get and return ScheduledAlertRule instead of AlertRule (its base class)
@AutorestCI AutorestCI requested a review from lmazuel as a code owner April 8, 2019 08:17
@AutorestCI AutorestCI mentioned this pull request Apr 8, 2019
Closed
5 tasks
@AutorestCI
Copy link
Copy Markdown
Contributor Author

AutorestCI commented Apr 8, 2019 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-securityinsight

You can install the package azure-mgmt-securityinsight of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5573#egg=azure-mgmt-securityinsight&subdirectory=azure-mgmt-securityinsight"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5573#egg=azure-mgmt-securityinsight&subdirectory=azure-mgmt-securityinsight"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5573
  • pip install -e ./azure-mgmt-securityinsight

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5573
  • pip wheel --no-deps ./azure-mgmt-securityinsight

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #4797 into restapi_auto_securityinsights/resource-manager will increase coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@                                Coverage Diff                                 @@
##           restapi_auto_securityinsights/resource-manager    #4797      +/-   ##
==================================================================================
+ Coverage                                           51.49%   53.76%   +2.26%     
==================================================================================
  Files                                               10985     9796    -1189     
  Lines                                              247440   209935   -37505     
==================================================================================
- Hits                                               127415   112866   -14549     
+ Misses                                             120025    97069   -22956
Impacted Files Coverage Δ
...ion/face/models/name_and_user_data_contract_py3.py 62.5% <0%> (-37.5%) ⬇️
...edia/azure/mgmt/media/models/job_input_clip_py3.py 60% <0%> (-11.43%) ⬇️
.../azure/mgmt/monitor/models/metric_dimension_py3.py 55.55% <0%> (-11.12%) ⬇️
...e/mgmt/monitor/models/metric_alert_criteria_py3.py 66.66% <0%> (-10.26%) ⬇️
...dia/azure/mgmt/media/models/job_input_asset_py3.py 62.5% <0%> (-10.23%) ⬇️
...dia/models/built_in_standard_encoder_preset_py3.py 62.5% <0%> (-10.23%) ⬇️
...-mgmt-media/azure/mgmt/media/models/overlay_py3.py 42.85% <0%> (-10.09%) ⬇️
...8_08_01/models/p2_svpn_server_configuration_py3.py 25% <0%> (-9.79%) ⬇️
...t-media/azure/mgmt/media/models/video_layer_py3.py 42.85% <0%> (-9.78%) ⬇️
...re-mgmt-media/azure/mgmt/media/models/image_py3.py 54.54% <0%> (-9.75%) ⬇️
... and 1369 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7c4c1...ca5735c. Read the comment docs.

@lmazuel lmazuel closed this May 24, 2019
@lmazuel lmazuel deleted the restapi_auto_5573 branch May 24, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

RestPRInProgress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AutorestCI @codecov-io @lmazuel @azuresdkci